pnowojski commented on a change in pull request #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#discussion_r318039891
########## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/streamstatus/StatusWatermarkValveTest.java ########## @@ -403,22 +406,30 @@ public void testNoOutputWhenAllActiveChannelsAreUnaligned() throws Exception { assertEquals(null, valveOutput.popLastSeenOutput()); } - private class BufferedValveOutputHandler implements StatusWatermarkValve.ValveOutputHandler { + private static class StatusWatermarkOutput implements PushBasedAsyncDataInput.DataOutput { + private BlockingQueue<StreamElement> allOutputs = new LinkedBlockingQueue<>(); @Override - public void handleWatermark(Watermark watermark) { + public void emitWatermark(Watermark watermark) { allOutputs.add(watermark); } @Override - public void handleStreamStatus(StreamStatus streamStatus) { + public void emitStreamStatus(StreamStatus streamStatus) { allOutputs.add(streamStatus); } + @Override + public void emitRecord(StreamRecord record) { + } + + @Override + public void emitLatencyMarker(LatencyMarker latencyMarker) { Review comment: `throw new UnsupportedOperationException`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services