pnowojski commented on a change in pull request #9478: [FLINK-13766][task]
Refactor the implementation of StreamInputProcessor based on
StreamTaskInput#emitNext
URL: https://github.com/apache/flink/pull/9478#discussion_r318032267
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamOneInputProcessor.java
##########
@@ -188,26 +132,59 @@ public void close() throws IOException {
input.close();
}
- private class ForwardingValveOutputHandler implements
StatusWatermarkValve.ValveOutputHandler {
+ /**
+ * The network data output implementation used for processing stream
elements
+ * from {@link StreamTaskNetworkInput} in one input processor.
+ */
+ private class StreamTaskNetworkOutput implements DataOutput<IN> {
Review comment:
Shouldn't the name be more generic and not connected with `Network`? Isn't
the same class going to be used for the source reader?
Maybe if we are not sure about that, we can leave this as it is now and
resolve it once we add `SourceReader` support?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
