JingsongLi commented on a change in pull request #9484: [FLINK-13774][table]
Expression DSL use should resolve Expressions in blink
URL: https://github.com/apache/flink/pull/9484#discussion_r318362631
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/ResolvedAggLocalReference.java
##########
@@ -20,19 +20,23 @@
import org.apache.flink.table.expressions.Expression;
import org.apache.flink.table.expressions.ExpressionVisitor;
+import org.apache.flink.table.expressions.ResolvedExpression;
+import org.apache.flink.table.types.DataType;
import org.apache.flink.table.types.logical.LogicalType;
import java.util.Collections;
import java.util.List;
+import static
org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter.fromLogicalTypeToDataType;
+
/**
* Special reference which represent a local filed, such as aggregate buffers
or constants.
* We are stored as class members, so the field can be referenced directly.
* We should use an unique name to locate the field.
*
* <p>See {@link
org.apache.flink.table.planner.codegen.ExprCodeGenerator#visitLocalRef}.
*/
-public class ResolvedAggLocalReference implements Expression {
+public class ResolvedAggLocalReference implements ResolvedExpression {
Review comment:
`LocalReferenceExpression` is never be null because it is used for a group
window in window aggregation.
But if it is used for aggregate buffer, it should be nullable, so we need a
`nullTerm`. If not, how do we identify its null attribute?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
