JingsongLi commented on a change in pull request #9484: [FLINK-13774][table]
Expression DSL use should resolve Expressions in blink
URL: https://github.com/apache/flink/pull/9484#discussion_r318543339
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkLocalRef.scala
##########
@@ -23,18 +23,16 @@ import org.apache.calcite.rel.`type`.RelDataType
import org.apache.calcite.rex.RexLocalRef
/**
- * Special reference which represent a local filed, such as aggregate buffers
or constants.
+ * Special reference which represent a local field, such as aggregate buffers
or constants.
* We are stored as class members, so the field can be referenced directly.
* We should use an unique name to locate the field.
*
* See
[[org.apache.flink.table.planner.codegen.ExprCodeGenerator.visitLocalRef()]]
*/
-case class RexAggLocalVariable(
+case class LocalReference(
fieldTerm: String,
- nullTerm: String,
- dataType: RelDataType,
- internalType: LogicalType)
- extends RexLocalRef(0, dataType)
+ dataType: RelDataType)
+ extends RexLocalRef(0, dataType)
Review comment:
Good point! I think we can use new `RexVariable` instead of `RexLocalRef`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
