wzhero1 commented on issue #9336: [FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application URL: https://github.com/apache/flink/pull/9336#issuecomment-526014631 @tillrohrmann @walterddr Thank you very much for the discussion~ I think maybe there are two places we should test. 1. the configuration we configured in Cli could be correctly parsed into YARN dynamic configuration. I found in `YARNSessionCapacitySchedulerITCase#testVCoresAreSet...()`, the method would getFlinkConfig by quering the yarn cluster. I added a priority config in this method, and it could correctly be parsed, which means the flinkConfiguration has the property when `AbstractYarnClusterDescriptor#startAppMaster()`, so we can infer the property can be well configured in the `ApplicationSubmissionContext`(and debugging can confirm this Inference ). Also I found `FlinkYarnSessionCliTest#testConfigurationBeforeDeployment()` I added before is redundant so I have deleted this test. https://github.com/apache/flink/blob/17e2747e575cc4d9847be76b5ce9a75a7b6707f7/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java#L254 2. after sumbitting the application, we should get the priority report from `ApplicationReport` to check whether the priority config takes effect. `YARNSessionCapacitySchedulerITCase#testVCoresAreSet...()` also provides the way to check the `ApplicationReport`. But in hadoop-2.4.1 api, the `ApplicationReport` does not provide the `getPriority()` method(the method is supported after 2.8.0). So in current flink(hadoop version:2.4.1), we could not to test the `ApplicationReport`. Since currently `ApplicationSubmissionContext` is wrapped in the `AbstractYarnClusterDescriptor#startAppMaster` and hard to get and test, so I think maybe it is proper to test as I talked above. I sumbitted a new commit as I said, looking forward to your better ideas, thanks~
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
