wzhero1 commented on issue #9336: [FLINK-13548][Deployment/YARN]Support 
priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#issuecomment-526078399
 
 
   Besides, it seems that using mocks to test 
`AbstractYarnClusterDescriptor#startAppMaster()` is very difficult. That method 
relies on too many dependencies which cannot be mocked properly, e.g. 
`setupSingleLocalResource()` relies on a local jar and copies it to HDFS.
   
   Could we just test the configuration parse in this commit (like other 
existing test cases), and refactor the 
`AbstractYarnClusterDescriptor#startAppMaster()` in another commit?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to