wuchong edited a comment on issue #9433: [FLINK-13708] [table-planner-blink] transformations should be cleared after execution in blink planner URL: https://github.com/apache/flink/pull/9433#issuecomment-526051349 > No you don't buffer in this PR in the `explain` method. In the explain method you just generate `StreamGraph` from the transformations you got in the explain method. Which is correct. Yes. We didn't buffer transformations for `explain` method. > There is actually one more thing that I don't necessarily like about it. The `Planner` has to construct the `Executor` which violates the clear seperation of logical/relational planning and physcial/execution planning. How about we add a method `explain` to the Executor as well. This method would explain the physical part. How about add a `String explainExecutionPlan(List<Transformation<?>>)` ? `explain` is too generic and it doesn't return logical parts.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
