[
https://issues.apache.org/jira/browse/FLINK-13147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-13147.
------------------------------------
Resolution: Fixed
master: b941ea8af517238f73299923c491175a8e88fc93
> Duplicated code in 'if' conditional statement
> ----------------------------------------------
>
> Key: FLINK-13147
> URL: https://issues.apache.org/jira/browse/FLINK-13147
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Hive
> Affects Versions: 1.6.3, 1.6.4, 1.7.2, 1.8.0, 1.8.1
> Reporter: lixiaobao
> Assignee: Ji Liu
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> } else if (type.equals(LogicalTypeRoot.VARBINARY)
> || type.equals(LogicalTypeRoot.BINARY)
> || type.equals(LogicalTypeRoot.BINARY)) {
> if (colStat instanceof CatalogColumnStatisticsDataBinary) {
> CatalogColumnStatisticsDataBinary binaryColumnStatsData =
> (CatalogColumnStatisticsDataBinary) colStat;
> BinaryColumnStatsData binaryColumnStats = new
> BinaryColumnStatsData(binaryColumnStatsData.getMaxLength(),
> binaryColumnStatsData.getAvgLength(), binaryColumnStatsData.getNullCount());
> return ColumnStatisticsData.binaryStats(binaryColumnStats);
> }{code}
> The class HiveStatsUtil have duplicated code in 'if' conditional statement.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
