tillrohrmann commented on a change in pull request #9575: [FLINK-13912][client]
Remove ClusterClient#getClusterConnectionInfo
URL: https://github.com/apache/flink/pull/9575#discussion_r319570322
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -513,12 +509,8 @@ private void
validateClusterSpecification(ClusterSpecification clusterSpecificat
yarnApplication,
validClusterSpecification);
- String host = report.getHost();
- int port = report.getRpcPort();
-
- // Correctly initialize the Flink config
- flinkConfiguration.setString(JobManagerOptions.ADDRESS, host);
- flinkConfiguration.setInteger(JobManagerOptions.PORT, port);
Review comment:
I'm not 100% sure that we can remove this update operation. A quick search
revealed that the `ResultStore` uses the `JobManagerOptions.ADDRESS`. Since I
could not rule out that we implicitly rely on the fact that the
`flinkConfiguration` is shared, I would not remove this setting. Only if we are
sure, ideally guarded by a test, then we should remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
