tillrohrmann commented on a change in pull request #9575: [FLINK-13912][client]
Remove ClusterClient#getClusterConnectionInfo
URL: https://github.com/apache/flink/pull/9575#discussion_r319565959
##########
File path:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala
##########
@@ -277,8 +277,9 @@ object FlinkShell {
val cluster = clusterDescriptor.deploySessionCluster(clusterSpecification)
- val inetSocketAddress = AkkaUtils.getInetSocketAddressFromAkkaURL(
- cluster.getClusterConnectionInfo.getAddress)
+ val webMonitorUrl = new URL(cluster.getWebInterfaceURL)
+
+ val inetSocketAddress = new InetSocketAddress(webMonitorUrl.getHost,
webMonitorUrl.getPort)
Review comment:
I guess we should make it consistent with `fetchDeployedYarnClusterInfo`. In
fact, I think that not trying to resolve the host name might actually be better
because Akka expects that messages arrive with the same hostname which it was
configured with at start up time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
