zentol commented on a change in pull request #9558: [FLINK-13892][hs] Harden
HistoryServerTest
URL: https://github.com/apache/flink/pull/9558#discussion_r319871696
##########
File path:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java
##########
@@ -131,11 +132,11 @@ public void testHistoryServerIntegration() throws
Exception {
archives = jmDirectory.listFiles();
Review comment:
Regarding the loop, I suppose we don't technically need it but it can speed
up the test.
We had the polling approach in the past but it wasn't particularly stable
and way more complicated than the current approach since you have to deal with
quite a few error cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
