zentol commented on a change in pull request #9558: [FLINK-13892][hs] Harden
HistoryServerTest
URL: https://github.com/apache/flink/pull/9558#discussion_r320730108
##########
File path:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java
##########
@@ -131,11 +132,11 @@ public void testHistoryServerIntegration() throws
Exception {
archives = jmDirectory.listFiles();
Review comment:
With the current settings it can speed things up since the first poll of the
HS is more likely to fetch all archives.
Another benefit is that it is easier to tell whether the archiving has
failed or not. Without the first loop, if the archiving on the JM fails the HS
we'd never execute the callback; in this case we'd only know that _something_
went wrong. With the dedicated loop to check the JM archiving it is easier to
pinpoint which component is experiencing problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
