kl0u commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-527077038 @yxu-valleytider in the example you present what you want to be able to do with the changes in terms of code. But can you describe the functionality that you think is missing from the `StreamingFileSink` and makes you want to subclass it instead of providing an alternative rolling policy for example or writer factory? In general I think that the idea of making the `StreamingFileSink` extendable is good. I am just wondering what additional functionality users may want.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
