kl0u commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-528577524 I will have a look first thing in the morning. In general changes look good, but I would like to have another pass. Also I think it is worth adding a test that verifies that we can change the type of the `BucketID` without problems. Essentially testing the `withBucketAssigner()` and the corresponding `withBucketAssignerAndPolicy()` for the `rowFormat` builder. This is mainly to guarantee that nobody will break it in the future. Such a test should have been added earlier when the initial `StreamingFileSink` was written :( .
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
