kl0u commented on a change in pull request #9581: [FLINK-13864][streaming]: 
Modify the StreamingFileSink Builder interface to allow for easier subclassing 
of StreamingFileSink 
URL: https://github.com/apache/flink/pull/9581#discussion_r319887174
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java
 ##########
 @@ -96,6 +96,8 @@
                extends RichSinkFunction<IN>
                implements CheckpointedFunction, CheckpointListener, 
ProcessingTimeCallback {
 
 
 Review comment:
   This could move in the builder base class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to