azagrebin commented on a change in pull request #9558: [FLINK-13892][hs] Harden
HistoryServerTest
URL: https://github.com/apache/flink/pull/9558#discussion_r320715182
##########
File path:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java
##########
@@ -131,11 +132,11 @@ public void testHistoryServerIntegration() throws
Exception {
archives = jmDirectory.listFiles();
Review comment:
How does the loop speed up the test? because it even introduces a sleep
while `numExpectedArchivedJobs` just immediately gives a callback when
everything is done. Does `numExpectedArchivedJobs` not basically subsume the
loop time-wise? i.e. `numExpectedArchivedJobs` is done only when the loop is
done
Regarding the polling approach I'm fine with it if it has been already
discussed before.
It would be a separate issue anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
