azagrebin commented on a change in pull request #9558: [FLINK-13892][hs] Harden
HistoryServerTest
URL: https://github.com/apache/flink/pull/9558#discussion_r319847769
##########
File path:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java
##########
@@ -131,11 +132,11 @@ public void testHistoryServerIntegration() throws
Exception {
archives = jmDirectory.listFiles();
Review comment:
Is this while loop still needed after changing the verification approach or
`HistoryServer` will not monitor job files created after its start?
Also a side note, would it be a more incapsulated approach to poll
`MultipleJobsDetails` similar way in this loop until the expected, non-failed
state reached instead of instrumenting `HistoryServer` internals for testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
