kl0u commented on a change in pull request #9607: [FLINK-13946] Remove job
session related code from ExecutionEnvironment
URL: https://github.com/apache/flink/pull/9607#discussion_r320722263
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java
##########
@@ -146,21 +129,9 @@ private JobExecutorService
createJobExecutorService(Configuration configuration)
return miniCluster;
}
- @Override
- public void stop() throws Exception {
- synchronized (lock) {
- if (jobExecutorService != null) {
- jobExecutorService.close();
- jobExecutorService = null;
- }
- }
- }
-
- @Override
- public boolean isRunning() {
- synchronized (lock) {
- return jobExecutorService != null;
- }
+ private void stopExecutorService(final JobExecutorService
executorService) throws Exception {
Review comment:
I am not so familiar with this code and maybe @tillrohrmann has more to say
on the value of the `JobExecutorService`. In any case, I believe this is not
related to this PR and can be added in the future. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
