kl0u commented on a change in pull request #9607: [FLINK-13946] Remove job
session related code from ExecutionEnvironment
URL: https://github.com/apache/flink/pull/9607#discussion_r320722937
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java
##########
@@ -77,11 +70,11 @@
//
------------------------------------------------------------------------
public LocalExecutor() {
- this(null);
+ this(new Configuration());
}
public LocalExecutor(Configuration conf) {
- this.baseConfiguration = conf != null ? conf : new
Configuration();
+ this.baseConfiguration = checkNotNull(conf);
Review comment:
I am used to using the `checkNotNull` but it is true that the `@Nonnull` is
part of the whole java ecosystem so it may be worth using it instead. I would
like to see other arguments as well and I am always up for uniformizing coding
styles :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
