zentol commented on a change in pull request #9601: [FLINK-13894][web]Web Ui
add log url for subtask of vertex
URL: https://github.com/apache/flink/pull/9601#discussion_r320931733
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/overview/subtasks/job-overview-drawer-subtasks.component.html
##########
@@ -42,7 +42,10 @@
<tbody>
<tr *ngFor="let task of listOfTask; trackBy:trackTaskBy;">
<td nzLeft="0">
- {{ task.subtask }}
+ <span *ngIf="!task['resource-id'] || task['resource-id'] ===
'(unassigned)'; else hrefTpl">{{ task.subtask }}</span>
+ <ng-template #hrefTpl>
+ <a [routerLink]="['/task-manager',task['resource-id'],'logs']"
target="_blank">LOG {{ task.subtask }}</a>
Review comment:
why are we including the subtask ID in the link label? IMO this will just
confuse people as they will assume that there are different logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
