azagrebin commented on a change in pull request #8479: [FLINK-11193][State
Backends]Use user passed configuration overriding default configuration loading
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r321245108
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java
##########
@@ -144,7 +145,7 @@ public void testConfigureTimerService() throws Exception {
Assert.assertEquals("state.backend.rocksdb.timer-service.factory",
RocksDBOptions.TIMER_SERVICE_FACTORY.key());
// Fix the option value string and ensure all are covered
- Assert.assertEquals(2,
RocksDBStateBackend.PriorityQueueStateType.values().length);
+ Assert.assertEquals(3,
RocksDBStateBackend.PriorityQueueStateType.values().length);
Review comment:
also `UNDEFINED` assertion if we choose to go with it
`Assert.assertEquals("UNDEFINED",
RocksDBStateBackend.PriorityQueueStateType.UNDEFINED.toString());`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
