azagrebin commented on a change in pull request #8479: [FLINK-11193][State 
Backends]Use user passed configuration overriding default configuration loading 
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r321244762
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
 ##########
 @@ -716,6 +719,11 @@ public void enableTtlCompactionFilter() {
                enableTtlCompactionFilter = TernaryBoolean.TRUE;
        }
 
+       private PriorityQueueStateType 
resolvePriorityQueueStateType(PriorityQueueStateType origin) {
 
 Review comment:
   I am wondering if it is more user-friendly if we add setter/getter for this 
like we have for some other things.
   we can also use this getter with the resolution logic in 
`createKeyedStateBackend`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to