tillrohrmann commented on a change in pull request #9637: [FLINK-13884] Set
default delay for restart strategies to 1s
URL: https://github.com/apache/flink/pull/9637#discussion_r322338426
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategy.java
##########
@@ -92,12 +91,9 @@ public String toString() {
public static FailureRateRestartStrategyFactory
createFactory(Configuration configuration) throws Exception {
int maxFailuresPerInterval =
configuration.getInteger(RestartStrategyOptions.RESTART_STRATEGY_FAILURE_RATE_MAX_FAILURES_PER_INTERVAL);
- String failuresIntervalString =
configuration.getString(RestartStrategyOptions.RESTART_STRATEGY_FAILURE_RATE_FAILURE_RATE_INTERVAL);
- String timeoutString =
configuration.getString(AkkaOptions.WATCH_HEARTBEAT_INTERVAL);
Review comment:
This change should not be part of the parsing commit. I'll change it.
`WATCH_HEARTBEAT_INTERVAL` is no longer used and will be deprecated in #9553.
Moreover, I think it is better to separate configurations and try to make
things as explicit as possible without much magic happening underneath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
