tillrohrmann commented on a change in pull request #9637: [FLINK-13884] Set
default delay for restart strategies to 1s
URL: https://github.com/apache/flink/pull/9637#discussion_r322588959
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/NoOrFixedIfCheckpointingEnabledRestartStrategyFactory.java
##########
@@ -18,12 +18,14 @@
package org.apache.flink.runtime.executiongraph.restart;
+import java.time.Duration;
+
/**
* Default restart strategy that resolves either to {@link NoRestartStrategy}
or {@link FixedDelayRestartStrategy}
* depending if checkpointing was enabled.
*/
public class NoOrFixedIfCheckpointingEnabledRestartStrategyFactory extends
RestartStrategyFactory {
- private static final long DEFAULT_RESTART_DELAY = 0;
+ private static final long DEFAULT_RESTART_DELAY =
Duration.ofSeconds(1L).toMillis();
Review comment:
Yes, we can change it once we have replaced Scala `Duration` parsing logic.
I didn't want to further spread the usage of the Scala classes in the
`flink-runtime` module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
