tillrohrmann commented on a change in pull request #9663:
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r323237739
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
##########
@@ -365,6 +368,14 @@ public InputDependencyConstraint
getInputDependencyConstraint() {
return getJobVertex().getInputDependencyConstraint();
}
+ public void setSendScheduleOrUpdateConsumerMessage(final boolean
sendScheduleOrUpdateConsumerMessage) {
+ this.sendScheduleOrUpdateConsumerMessage =
sendScheduleOrUpdateConsumerMessage;
+ }
+
+ public boolean isSendScheduleOrUpdateConsumerMessage() {
+ return sendScheduleOrUpdateConsumerMessage;
+ }
Review comment:
As far as I can see from the other commits, we call the set method from
`DefaultExecutionVertexOperations` which is called when we deploy the
execution. However, the is method is being called when we register the produced
result partitions which happens before the deployment. I guess I don't
understand the control flow wrt these methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
