tillrohrmann commented on a change in pull request #9663: 
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r323222669
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ##########
 @@ -845,6 +853,10 @@ else if (current == CREATED || current == SCHEDULED) {
        }
 
        private void scheduleConsumer(ExecutionVertex consumerVertex) {
+               if (!vertex.isLegacyScheduling()) {
 
 Review comment:
   I think it would be better to use `isLegacyScheduling()` instead of 
`vertex.isLegacyScheduling()` across all legacy scheduling checks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to