tillrohrmann commented on a change in pull request #9663: 
[WIP][FLINK-12433][runtime] Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r323225160
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ##########
 @@ -1211,7 +1231,10 @@ private boolean processFail(Throwable t, boolean 
isCallback, Map<String, Accumul
                                return false;
                        }
 
-                       if (transitionState(current, FAILED, t)) {
+                       if (!isCallback && !isLegacyScheduling()) {
 
 Review comment:
   Could you explain why we have this check here? Maybe a clarifying code 
comment could help.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to