dianfu commented on a change in pull request #9653: [FLINK-14014][python] 
Introduce PythonScalarFunctionRunner to handle the communication with Python 
worker for Python ScalarFunction execution
URL: https://github.com/apache/flink/pull/9653#discussion_r323331954
 
 

 ##########
 File path: 
flink-python/src/main/java/org/apache/flink/python/PythonFunctionRunner.java
 ##########
 @@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.python;
+
+import org.apache.flink.annotation.Internal;
+
+/**
+ * The base interface of runner which is responsible for the execution of 
Python functions.
+ *
+ * @param <IN> Type of the input elements.
+ */
+@Internal
+public interface PythonFunctionRunner<IN> {
+
+       /**
+        * Prepares the Python function runner, such as preparing the Python 
execution environment, etc.
+        */
+       void open() throws Exception;
 
 Review comment:
   These methods can only be tested in integration test which can be only added 
after FLINK-14018. However, I'm in favor of keeping them as they are very 
important part of the functionality of PythonFunctionRunner. What about keeping 
these functionalities and we can revisit if these code could be well tested 
when adding integration tests in FLINK-14018?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to