zhuzhurk commented on a change in pull request #8912: [FLINK-12709] [runtime]
Implement new generation restart strategy loader which also respects legacy…
URL: https://github.com/apache/flink/pull/8912#discussion_r323595466
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/RestartBackoffTimeStrategyOptions.java
##########
@@ -46,7 +57,7 @@
.withDescription("Time interval in milliseconds for measuring
failure rate.");
/**
- * Backoff time between two consecutive restart attempts in
FailureRateRestartBackoffTimeStrategy.
+ * Backoff time (milli-seconds) between two consecutive restart
attempts in FailureRateRestartBackoffTimeStrategy.
*/
@PublicEvolving
public static final ConfigOption<Long>
RESTART_BACKOFF_TIME_STRATEGY_FAILURE_RATE_FAILURE_RATE_BACKOFF_TIME =
ConfigOptions
Review comment:
Good question. Previously the configs for strategy strategies are quite a
mess in ConfigConstants and I wanted to deprecate them. But with FLIP 61 the
configs are better organized in RestartStrategyOptions.java.
I think now we can use the configs from RestartStrategyOptions.java
directly. And I'm also thinking to rename RestartBackoffTimeStrategy to
RestartStrategy once we have removed the legacy RestartStrategy.
I will open a hotfix commit to migrate these options and their usages in
related strategy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
