zhuzhurk commented on a change in pull request #8912: [FLINK-12709] [runtime]
Implement new generation restart strategy loader which also respects legacy…
URL: https://github.com/apache/flink/pull/8912#discussion_r323598464
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/RestartBackoffTimeStrategyOptions.java
##########
@@ -25,6 +25,16 @@
*/
@PublicEvolving
public class RestartBackoffTimeStrategyOptions {
+
+ /**
+ * Class name of the RestartBackoffTimeStrategy implementation to use.
+ */
+ @PublicEvolving
+ public static final ConfigOption<String>
RESTART_BACKOFF_TIME_STRATEGY_CLASS_NAME = ConfigOptions
+ .key("restart-backoff-time-strategy.class-name")
Review comment:
Yes it is a breaking change if a user was using a custom RestartStrategy.
I will open a discussion to
1. notify users that previous custom RestartStrategy does not work in the
new scheduler anymore
2. discuss whether we should keep supporting custom
RestartBackoffTimeStrategy for existing custom RestartStrategy migration or
future use
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services