pnowojski commented on a change in pull request #9483: [FLINK-13767][task] 
Refactor StreamInputProcessor#processInput based on InputStatus
URL: https://github.com/apache/flink/pull/9483#discussion_r325139956
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
 ##########
 @@ -184,10 +184,6 @@ public boolean processInput() throws Exception {
                }
                checkFinished(status, lastReadInputIndex);
 
-               if (status != InputStatus.MORE_AVAILABLE) {
 
 Review comment:
   Some side effect of removing this code is that now `inputSelectionHandler` 
will be updated not immediately during this `#processInput(...)` invocation, 
but only during the next one, right? Could this cause any (performance?) issues?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to