pnowojski commented on a change in pull request #9483: [FLINK-13767][task]
Refactor StreamInputProcessor#processInput based on InputStatus
URL: https://github.com/apache/flink/pull/9483#discussion_r325290219
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
##########
@@ -184,10 +184,6 @@ public boolean processInput() throws Exception {
}
checkFinished(status, lastReadInputIndex);
- if (status != InputStatus.MORE_AVAILABLE) {
Review comment:
> are there any purpose to update the selection immediately before?
I'm not sure if there is any difference now, with the updated return status
code. Previously it was returning boolean "more available" for hot looping.
Without up to date input availability, it could attempt to read from incorrect
(empty) input and that would trigger a `volatile` `isAvailable()` access.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
