yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-532348389 @kl0u Agree with most of the review comments. Just want to re-iterate the main reason why introducing a third generics parameter in `RowFormatBuilder` and `BulkFormatBuilder` is due to the above https://github.com/apache/flink/pull/9581#issuecomment-527534328.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services