azagrebin commented on issue #9684: [FLINK-13992][coordination] Refactor Optional parameter in InputGateWithMetrics#updateMetrics URL: https://github.com/apache/flink/pull/9684#issuecomment-533109511 Sorry @TisonKun something is messed up with my Github notifications :) > IMO it is good to separate code style changes with feature efforts. In your words it seems you also agree this opinion but there is an "although" and following this statement I did not mean that we should separate code style changes with feature efforts. On the contrary, we usually avoid changes which are not related to some behavioural change, like feature or bug fix. If you do a lot of changes to some method or class to actually change something in Flink behaviour like feature or bug fix, you can also refactor its code style. This kind of changes are interesting to follow in the git history (annotate lines in IDE: commit, who changed and why) and they have value to understand the code. If you change just code style, nothing actually changes in Flink behaviour but you rewrite the git history for the changed lines. When somebody looks into the history of the changed lines, she is probably more interested in the previous changes and their description which is hidden after the code style improvement. All-in-all, it is again a trade-off. We want to have a good code style in the code for readability. On the other hand, we want to have a clear git history for the same purpose of readability. We usually choose the git history over the minor changes like code style because the git history is more valuable for understanding. That is why we prefer not to do unrelated changes as well and do not refactor older parts of code without a related purpose. Hope it helps. cc @tillrohrmann @pnowojski
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
