JingsongLi commented on a change in pull request #9721: [FLINK-14129][hive] 
HiveTableSource should implement ProjectableTable…
URL: https://github.com/apache/flink/pull/9721#discussion_r326449917
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableInputFormat.java
 ##########
 @@ -88,17 +86,23 @@
        private transient InputFormat mapredInputFormat;
        private transient HiveTablePartition hiveTablePartition;
 
+       // indices of fields to be returned, with projection applied (if any)
+       // TODO: push projection into underlying input format that supports it
 
 Review comment:
   I don't think underlying input format can support project push down. Any 
information or delete this comment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to