JingsongLi commented on a change in pull request #9721: [FLINK-14129][hive]
HiveTableSource should implement ProjectableTable…
URL: https://github.com/apache/flink/pull/9721#discussion_r326459821
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableInputFormat.java
##########
@@ -207,19 +211,22 @@ public Row nextRecord(Row ignore) throws IOException {
if (reachedEnd()) {
return null;
}
- Row row = new Row(rowArity);
+ Row row = new Row(fields.length);
Review comment:
Why not use the row in `nextRecord(Row ignore)`? with reuse this row, you
can never reassign partition values after initialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
