GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime]
Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r327145413
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -1129,6 +1157,9 @@ void failGlobalIfExecutionIsStillRunning(Throwable
cause, ExecutionAttemptID fai
* @param t The exception that caused the failure.
*/
public void failGlobal(Throwable t) {
+ if (!isLegacyScheduling()) {
+ ExceptionUtils.rethrow(t);
Review comment:
> Maybe we need to implement a failGlobal mechanism that works for
DefaultScheduler.
I think that's reasonable and it should be straightforward to do this.
Moreover, I think we should differentiate calls to `failGlobal()`. The
original contract for `failGlobal()` was that it is called when [_"the
consistency of the execution graph cannot be guaranteed
anymore"_](https://github.com/apache/flink/blob/8155d465520c4b616866d35395c3b10f7e809b78/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L1124).
Clearly this does not hold anymore. One example that you have alreayd
mentioned is the
[`CheckpointFailureManager`](https://github.com/apache/flink/blob/8155d465520c4b616866d35395c3b10f7e809b78/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L582)
– here calls to `failGlobal()` do not indicate consistency issues. For real
consistency issues caused by bugs, illegal state transitions, etc. I think it
is reasonable to terminate the JVM. One could propagate the exception to the
JobMaster and in the RPC framework check for unwanted uncaught exceptions in
specially annotated RPC methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
