GJL commented on a change in pull request #9663: [WIP][FLINK-12433][runtime]
Implement DefaultScheduler stub
URL: https://github.com/apache/flink/pull/9663#discussion_r327529268
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotProvider.java
##########
@@ -42,6 +42,23 @@
*/
public interface SlotProvider {
+ /**
+ * Allocating slot with specific requirement.
+ *
+ * @param slotRequestId identifying the slot request
+ * @param scheduledUnit The task to allocate the slot for
+ * @param slotProfile profile of the requested slot
+ * @param allocationTimeout after which the allocation fails with a
timeout exception
+ * @return The future of the allocation
+ */
+ default CompletableFuture<LogicalSlot> allocateSlot(
Review comment:
I think de facto there is only queued scheduling so the other method should
be removed. However, I am reverting my change because it's not needed for the
scheduler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
