carp84 commented on issue #9255: [FLINK-13034] Introduce isEmpty method for MapState URL: https://github.com/apache/flink/pull/9255#issuecomment-534844195 > There have been some tests for `MapState.isEmpty` in `StateBackendTestBase.testMapState`, do you actually mean other tests for `MapState.isEmpty` could be ignored？ @carp84 I meant to add an explicit `testMapStateIsEmpty` case like `testListStateAddNull` in `StateBackendTestBase` instead of squeezing everything in `testMapState`. Similarly, add an explicit `testIsEmpty` method in `ImmutableMapStateTest` instead of scattered statements in existing cases.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
