GJL commented on a change in pull request #8912: [FLINK-12709] [runtime]
Implement new generation restart strategy loader which also respects legacy…
URL: https://github.com/apache/flink/pull/8912#discussion_r328021824
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FixedDelayRestartBackoffTimeStrategy.java
##########
@@ -57,6 +58,11 @@ public long getBackoffTime() {
return backoffTimeMS;
}
+ @VisibleForTesting
+ int getMaxNumberRestartAttempts() {
Review comment:
I think it's reasonable to make this part of the public API, i.e., remove
`@VisibleForTesting` and add `public`. Generally speaking, if a value is
exposed by `toString()`, the value should be accessible by a getter or other
methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
