1u0 commented on a change in pull request #9773: [FLINK-14210][metrics]support connect timeout and write timeout confi… URL: https://github.com/apache/flink/pull/9773#discussion_r328190238
########## File path: docs/monitoring/metrics.md ########## @@ -659,6 +659,8 @@ Parameters: - `username` - (optional) InfluxDB username used for authentication - `password` - (optional) InfluxDB username's password used for authentication - `retentionPolicy` - (optional) InfluxDB retention policy, defaults to retention policy defined on the server for the db +- `connectTimeout` - (optional) the InfluxDB connect timeout, defaults to connect timeout is 10000 ms +- `writeTimeout` - (optional) the InfluxDB write timeout, defaults to write timeout is 10000 ms Review comment: I suggest to rephrase it, so it explicitly mentions unit of measure (milliseconds). Also, change the `defaults to connect/write timeout is ...` to `default is ...`. For example: ``` - `connectTimeout` - (optional) the InfluxDB client connect timeout in milliseconds, default is 10000 ms - `writeTimeout` - (optional) the InfluxDB client write timeout in milliseconds, default is 10000 ms ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
