1u0 commented on a change in pull request #9773: [FLINK-14210][metrics]support
connect timeout and write timeout confi…
URL: https://github.com/apache/flink/pull/9773#discussion_r328196949
##########
File path:
flink-metrics/flink-metrics-influxdb/src/test/java/org/apache/flink/metrics/influxdb/InfluxdbReporterTest.java
##########
@@ -126,6 +126,8 @@ private MetricRegistryImpl createMetricRegistry(String
retentionPolicy) {
metricConfig.setProperty(InfluxdbReporterOptions.PORT.key(),
String.valueOf(wireMockRule.port()));
metricConfig.setProperty(InfluxdbReporterOptions.DB.key(),
TEST_INFLUXDB_DB);
metricConfig.setProperty(InfluxdbReporterOptions.RETENTION_POLICY.key(),
retentionPolicy);
+
metricConfig.setProperty(InfluxdbReporterOptions.CONNECT_TIMEOUT.key(),
"10000");
+
metricConfig.setProperty(InfluxdbReporterOptions.WRITE_TIMEOUT.key(), "10000");
Review comment:
This is not actually needed (and tested anyhow).
Please remove this lines (as they are rather adding noise to the tests), OR
add actual tests that verify that http client is properly configured when there
are config options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
