zhijiangW commented on a change in pull request #9717: [FLINK-14044] [runtime]
Reducing synchronization in AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9717#discussion_r328414259
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/execution/MailboxProcessor.java
##########
@@ -200,7 +200,7 @@ private boolean processMail(TaskMailbox mailbox) throws
MailboxStateException, I
try {
maybeLetter.get().run();
} catch (Exception e) {
- e.printStackTrace();
+ throw new IllegalStateException("Cannot process
mail " + maybeLetter.get(), e);
Review comment:
From the description of `AsyncExceptionHandler`, it is proposed to used by
other threads except the main task thread. AFAIK it is only used by
`SplitReader` in `ContinuousFileReaderOperator` now. For this case if the
`processMail` is executed in the main task thread, maybe it is out of scope of
`AsyncExceptionHandler`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
