zhijiangW commented on a change in pull request #9717: [FLINK-14044] [runtime]
Reducing synchronization in AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9717#discussion_r328459063
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimestampedCollector.java
##########
@@ -71,4 +73,19 @@ public void eraseTimestamp() {
public void close() {
output.close();
}
+
+ @Override
+ public void emitWatermark(Watermark mark) {
+ output.emitWatermark(mark);
+ }
+
+ @Override
+ public <X> void collect(OutputTag<X> outputTag, StreamRecord<X> record)
{
Review comment:
It is involved in three new methods by implementing `Output` interface
instead. But actually we only need the `emitWatermark` method, and the left two
methods would never be touched in current codes. If so, another option is that
we can only define `emitWatermark` method here and still implement `Collector`
interface.
Or we could refactor the previous usages of `TimestampedCollector` to reuse
the other two methods for avoiding touching the internal wrapped `output`
directly. It might be out of this PR scope or a separate hotfix commit if you
want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
