aljoscha commented on a change in pull request #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#discussion_r329026958
########## File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,45 @@ +flink-sql-connector-elasticsearch7 Review comment: Did you check whether the contents of the new `NOTICE` file is correct? A quick `mvn dependency:tree` on the new sql connector shows some dependencies that are not in the `NOTICE` file. I think these are new compared to ES6, which didn't have them. You can compare the output of `mvn depdendency:tree` on the ES6 sql jar and on the new ES7 sql jar and also compare to the `NOTICE` files. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
