aljoscha commented on a change in pull request #9720: [FLINK-13025] Elasticsearch 7.x support URL: https://github.com/apache/flink/pull/9720#discussion_r329635982
########## File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE ########## @@ -0,0 +1,45 @@ +flink-sql-connector-elasticsearch7 Review comment: Quite some of the dependencies are test dependencies or transitive dependencies of test dependencies, I don't think they should be added here. For some other dependencies, I only noticed this now but the maven shade configuration excludes some dependencies, so they also should not be added here. I'm also wondering which of the newly added dependencies to exclude here. Maybe @twalthr, who created the first versions of the ES6 table connector can shed some light on this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
