[ https://issues.apache.org/jira/browse/FLINK-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939438#comment-16939438 ]
Kostas Kloudas edited comment on FLINK-14250 at 9/27/19 1:30 PM: ----------------------------------------------------------------- I think that this a pretty important clean-up. The whole CLI logic is pretty complicated because some parts have not clear responsibilities. For example, the {{ProgramOptions}} parse the cli options but validation happens partially there but also in the {{CliFrontend}}. For an example see the {{CliFrontend.buildProgram()}} or theĀ {{CliFrontend.run()}} and more specifically the {{if (!programOptions.isPython()) ...}}. With a dedicated {{Python}} command, this logic can be contained in a separate class. was (Author: kkl0u): I think that this a pretty important clean-up. The whole CLI logic is pretty complicated because some parts have not clear responsibilities. For example, the {{ProgramOptions}} parse the cli options but validation happens partially there but also in the {{CliFrontend}}. For an example see the {{CliFrontend.run()}} and more specifically the {{if (!programOptions.isPython()) ...}}. With a dedicated {{Python}} command, this logic can be contained in a separate class. > Introduce separate "bin/flink runpy" and remove python support from > "bin/flink run" > ----------------------------------------------------------------------------------- > > Key: FLINK-14250 > URL: https://issues.apache.org/jira/browse/FLINK-14250 > Project: Flink > Issue Type: Sub-task > Components: Client / Job Submission > Reporter: Aljoscha Krettek > Priority: Major > > Currently, "bin/flink run" supports both Java and Python programs and there > is quite some complexity in command line parsing and validation and the code > is spread across different classes. > I think if we had a separate "bin/flink runpy" then we could simplify the > parsing quite a bit and the usage help of each command would only show those > options that are relevant for the given use case. -- This message was sent by Atlassian Jira (v8.3.4#803005)