twalthr commented on a change in pull request #9748:
[FLINK-14016][python][flink-table-planner] Introduce DataStreamPythonCalc for
Python function execution
URL: https://github.com/apache/flink/pull/9748#discussion_r329575228
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/FunctionDefinition.java
##########
@@ -40,6 +40,13 @@
*/
FunctionKind getKind();
+ /**
+ * Returns the language of function this definition describes.
+ */
+ default FunctionLanguage getLanguage() {
Review comment:
@hequn8128 I just had a brief look at this change. I already mentioned my
concern on the ML discussion. Why should users be able to override this
property. `UserDefinedFunction` should mark this method `final` similar to
`ScalarFunction#getKind`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
