twalthr commented on a change in pull request #9748:
[FLINK-14016][python][flink-table-planner] Introduce DataStreamPythonCalc for
Python function execution
URL: https://github.com/apache/flink/pull/9748#discussion_r331506354
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/FunctionDefinition.java
##########
@@ -40,6 +40,13 @@
*/
FunctionKind getKind();
+ /**
+ * Returns the language of function this definition describes.
+ */
+ default FunctionLanguage getLanguage() {
Review comment:
From an architectural point of view, I'm unsure if a Python function should
be a `UserDefinedFunction`. Because it is more a system bridging function for
executing Python UDFs.
As far as I can see you already do `implements PythonFunction`; isn't that
enough information? I still don't understand why users need to be able to
override a `getLanguage()` method. When is this method read?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
