GJL commented on a change in pull request #9794: [FLINK-14247][runtime] Use
NoResourceAvailableException to wrap TimeoutException on slot allocation timeout
URL: https://github.com/apache/flink/pull/9794#discussion_r329570326
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/NoResourceAvailableException.java
##########
@@ -19,40 +19,20 @@
package org.apache.flink.runtime.jobmanager.scheduler;
import org.apache.flink.runtime.JobException;
-import org.apache.flink.runtime.throwable.ThrowableAnnotation;
-import org.apache.flink.runtime.throwable.ThrowableType;
-@ThrowableAnnotation(ThrowableType.NonRecoverableError)
+/**
+ * Indicates resource allocation failures.
+ */
public class NoResourceAvailableException extends JobException {
Review comment:
I assume there is no semantical change if we remove
`@ThrowableAnnotation(ThrowableType.NonRecoverableError)` because
`ThrowableClassifier` was never really used, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
